The incidence of non-union in the shaft of femur is increasing gradually in spite of considerably improved methods of femoral fracture care. It is necessary that orthopaedic surgeon must draw attention to improve the method of treatment and to prevent the occurance of non-union. This paper presents the follow-up result of 27 cases among 30 established femoral shaft non-union cases, that were treated at the orthopaedic dept. of the National Medical Center from March 1971 to March 1980 by various methods. The study of this series shows the following. l. Amount 27 cases, male was predominant (82%), peak age group was 3rd & 4th decades (52%). 2. The causes of injury were auto-accident (56%), falling down accident (22%), direct blow (11%) & slipping down accident (11%). 3. The most common location was around the mid-shaft of femur (44.4%). 4. The probable causes of non-union were loosening of the implants & metal failure due to improper internal fixation (10 cases), incomplete reduction (7 cases), infection (5 cases) & inadenaute external immobilization (5 cases). 5. Excellent results were obtained by combined method of compression plate, screws & intramedullary nailing with additional autogenous bone graft.